This is the mail archive of the
archer@sourceware.org
mailing list for the Archer project.
Re: using directive patch
- From: Tom Tromey <tromey at redhat dot com>
- To: Sami Wagiaalla <swagiaal at redhat dot com>
- Cc: Project Archer <archer at sourceware dot org>
- Date: Fri, 05 Sep 2008 13:14:03 -0600
- Subject: Re: using directive patch
- References: <48BED230.1070209@redhat.com>
- Reply-to: Tom Tromey <tromey at redhat dot com>
>>>>> "Sami" == Sami Wagiaalla <swagiaal@redhat.com> writes:
Sami> The above is the only variation I test. There is more to come, but I
Sami> wanted to get some feed back early on.
I don't understand it all, but it looks reasonable to me.
There are a number of formatting nits, but that is nothing much to
worry about. The GNU Coding Standards cover how this code ought to
look.
It would be nice if this could be done without a new global variable,
but I understand that you're copying existing practice.
One important thing for merging (to archer trunk) is test cases.
Ideally the tests would specify expected behavior, both ordinary and
error cases.
Tom