Re: [python] Implement gdb.search_memory.

[Tom Tromey <tromey at redhat dot com>]

>>>>> "Thiago" == Thiago Jung Bauermann <bauerman@br.ibm.com> writes:

Thiago> This is not the issue here, it seems. But do we want to enforce
Thiago> backward/forward compatibility for each pushed commit? 

No, a best effort is enough.  These sorts of bugs tend to be trivial
to fix; it isn't worth that amount of overhead.  Well, unless perhaps
someone wants to automate it for us...


I do have a couple follow-up suggestions.

A few functions in python-membuf.c are not static but probably should
be.  E.g., get_read_buffer.  (Or, if you intend to export that, give
it a less generic name.)

Also, mbpy_str still casts a CORE_ADDR to a void*, which is bad.
Daniel suggested using paddr or paddr_nz here.

Tom