This is the mail archive of the archer@sourceware.org mailing list for the Archer project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Fixes for Mac OS X/x86 building/running


>>>>> "Tom" == Tom Tromey <tromey@redhat.com> writes:

Tom> I suspect you must have added the NULL in the wrong spot
[...]

I checked in this patch on the archer-tromey-delayed-symfile branch.
It ought to fix this bug.  I also noticed another instance of this
problem, so I fixed it as well.

If you have the archer branch checked out, you can merge this over.
The commit itself is 1018589cd4646267c3dfc2225d1227f25a85f644, but
there's a merge after it on the branch since I forgot to pull
first... sigh.

Maybe it is time to submit the delayed symfile patch upstream.
I'm having trouble thinking of a reason why not.

Tom

2009-03-12  Jonas Maebe  <jonas.maebe@elis.ugent.be>
	    Tom Tromey  <tromey@redhat.com>

	* somread.c (som_sym_fns): Add sym_read_psymbols entry.
	* machoread.c (macho_sym_fns): Add sym_read_psymbols entry.

diff --git a/gdb/machoread.c b/gdb/machoread.c
index d8d3bd2..248fae2 100644
--- a/gdb/machoread.c
+++ b/gdb/machoread.c
@@ -681,6 +681,7 @@ static struct sym_fns macho_sym_fns = {
   macho_new_init,               /* sym_new_init: init anything gbl to entire symtab */
   macho_symfile_init,           /* sym_init: read initial info, setup for sym_read() */
   macho_symfile_read,           /* sym_read: read a symbol file into symtab */
+  NULL,				/* sym_read_psymbols */
   macho_symfile_finish,         /* sym_finish: finished with file, cleanup */
   macho_symfile_offsets,        /* sym_offsets:  xlate external to internal form */
   NULL                          /* next: pointer to next struct sym_fns */
diff --git a/gdb/somread.c b/gdb/somread.c
index 36a2b28..4d5bda9 100644
--- a/gdb/somread.c
+++ b/gdb/somread.c
@@ -435,6 +435,7 @@ static struct sym_fns som_sym_fns =
   som_new_init,			/* sym_new_init: init anything gbl to entire symtab */
   som_symfile_init,		/* sym_init: read initial info, setup for sym_read() */
   som_symfile_read,		/* sym_read: read a symbol file into symtab */
+  NULL,				/* sym_read_psymbols */
   som_symfile_finish,		/* sym_finish: finished with file, cleanup */
   som_symfile_offsets,		/* sym_offsets:  Translate ext. to int. relocation */
   default_symfile_segments,	/* sym_segments: Get segment information from


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]