Re: [patch] Do not allow invalid subscript operations on GDB values

[Phil Muldoon <pmuldoon at redhat dot com>]

On 09/15/2009 09:43 PM, Tom Tromey wrote:
> If that fails, please add the call and commit it.
> If it works, it is ok as-is, so please commit it.
>
> Also, please submit the final patch upstream.
>
>    

Tom,

Thanks for looking at the patch. In an additional test I added, the 
reference fails without coerce_ref. So ... I added the coerce_ref back 
into the code. The only way I could think to test this is to add C++ 
bits to the testcase. But I'm not totally sure that I am testing your 
original concern. So before I commit, can you give it one more once 
over? The patch is pretty much the same other than the coerce_ref call, 
and the addition of the C++ test. Thanks!

Regards

Phil

Attachment: py_subscript_a2.patch
Description: Text document