This is the mail archive of the archer@sourceware.org mailing list for the Archer project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [patch] Do not allow invalid subscript operations on GDB values


>>>>> "Phil" == Phil Muldoon <pmuldoon@redhat.com> writes:

Phil> Thanks for looking at the patch. In an additional test I added, the
Phil> reference fails without coerce_ref. So ... I added the coerce_ref back
Phil> into the code. The only way I could think to test this is to add C++
Phil> bits to the testcase. But I'm not totally sure that I am testing your
Phil> original concern. So before I commit, can you give it one more once
Phil> over? The patch is pretty much the same other than the coerce_ref
Phil> call, and the addition of the C++ test. Thanks!

Looks good, thanks!

Tom


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]