This is the mail archive of the archer@sourceware.org mailing list for the Archer project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: Patch to add rtti_type member to gdb.Value

From: Tom Tromey <tromey at redhat dot com>
To: Richard Ward <richard dot j dot ward1 at googlemail dot com>
Cc: archer at sourceware dot org
Date: Fri, 25 Sep 2009 14:43:13 -0600
Subject: Re: Patch to add rtti_type member to gdb.Value
References: <4ABA6ADD.4000003@googlemail.com><m3fxaayhh8.fsf@fleche.redhat.com> <4ABD179F.6050006@googlemail.com>
Reply-to: Tom Tromey <tromey at redhat dot com>

>>>>> "Richard" == Richard Ward <richard.j.ward1@googlemail.com> writes:

Richard> I'll look at the other points later when I have time, but In this case
Richard> if Py_None is used it will be incremented twice before being handed
Richard> back to the caller.

Yeah -- once for the store to obj->type, and once for the caller.
The caller needs a new reference, always.
For obj->type, this lets us call Py_DECREF without checking whether
obj->type is None.

Tom

References:
- Patch to add rtti_type member to gdb.Value
  - From: Richard Ward
- Re: Patch to add rtti_type member to gdb.Value
  - From: Tom Tromey
- Re: Patch to add rtti_type member to gdb.Value
  - From: Richard Ward

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]