Re: gdbstub initial code, v3

[Oleg Nesterov <oleg at redhat dot com>]

On 08/12, Oleg Nesterov wrote:
>
> Problems:
>
> 	- It doesn't support all-stop mode.
>
> 	  Please tell me if this is needed. I hope not, this needs
> 	  a lot of nasty complications :/
>
> 	- We should discuss utrace limitations: UTRACE_RESUME
> 	  races/problems, utrace_prepare_examine() issues.
>
> 	- I just finished this code, and it doesn't work with gdb ;)

Noticed the typo in ugdb.c, it needs this one-liner fix:

	--- x/ugdb.c
	+++ x/ugdb.c
	@@ -603,7 +603,7 @@ static int ugdb_cont_thread(struct ugdb_
		ugdb_ck_stopped(ugdb);
	 
		// XXX: gdb shouldn't explicitly cont an unreported thread
	-	WARN_ON(!all && !(thread->t_stop_state == T_STOP_STOPPED));
	+	WARN_ON(!all && !(thread->t_stop_state & T_STOP_STOPPED));
	 
		if (thread->t_stop_state == T_STOP_RUN)
			return 0;

I attached the patched ugdb.c.

> 	  I will investigate tomorrow, but I am almost sure gdb is
> 	  wrong.

Yes, this seems to be true... Tomorrow.

Oleg.

Attachment: ugdb.c
Description: Text document