This is the mail archive of the binutils@sourceware.cygnus.com mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]

PATCH for elf32-mips.c typo



I checked in the following one-line fix.  On N32/64 MIPS ELF, you can
have multiple relocations with the same offset; an R_MIPS_NONE
relocation, however, marks the end of a sequence.  The current code
didn't check that condition correctly.

--
Mark Mitchell                   mark@codesourcery.com
CodeSourcery, LLC               http://www.codesourcery.com

1999-07-28  Mark Mitchell  <mark@codesourcery.com>

	* elf32-mips.c (_bfd_mips_elf_relocate_section): Fix typo.

Index: elf32-mips.c
===================================================================
RCS file: /cvs/binutils/binutils/bfd/elf32-mips.c,v
retrieving revision 1.33
diff -c -p -r1.33 elf32-mips.c
*** elf32-mips.c	1999/07/21 23:32:29	1.33
--- elf32-mips.c	1999/07/28 08:07:36
*************** _bfd_mips_elf_relocate_section (output_b
*** 6601,6607 ****
  	 for the next.  */
        if (rel + 1 < relend 
  	  && rel->r_offset == rel[1].r_offset
! 	  && r_type != R_MIPS_NONE)
  	use_saved_addend_p = true;
        else
  	use_saved_addend_p = false;
--- 6601,6607 ----
  	 for the next.  */
        if (rel + 1 < relend 
  	  && rel->r_offset == rel[1].r_offset
! 	  && ELF32_R_TYPE (rel[1].r_info) != R_MIPS_NONE)
  	use_saved_addend_p = true;
        else
  	use_saved_addend_p = false;

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]