This is the mail archive of the
binutils@sourceware.cygnus.com
mailing list for the binutils project.
Re: Patch: add pa2.0 64 bit condition completers (2nd try)
- To: "Jerry Quinn" <jquinn@nortelnetworks.com>
- Subject: Re: Patch: add pa2.0 64 bit condition completers (2nd try)
- From: Jeffrey A Law <law@cygnus.com>
- Date: Fri, 06 Aug 1999 09:50:24 -0600
- cc: binutils@sourceware.cygnus.com
- Reply-To: law@cygnus.com
In message <199907291433.HAA06298@cygnus.com>you write:
> There was an undefined variable that shouldn't have been there. Here is
> the patch again without it.
>
> Wed Jul 28 15:11:09 EDT 1999 Jerry Quinn <jquinn@nortelnetworks.com>
>
> * gas/config/tc-hppa.c (pa_ip): Add 64 bit condition completers.
> * include/opcode/hppa.h: Document 64 bit condition completers.
> * opcodes/hppa-dis.c (compare_cond_64_names, cmpib_cond_64_names,
> add_cond_64_names, wide_add_cond_names, logical_cond_64_names,
> unit_cond_64_names, shift_cond_64_names, bb_cond_64_names): New.
> (print_insn_hppa): Add 64 bit condition completers.
Thanks. A few comments.
> ***************
> *** 1733,1738 ****
> --- 1734,1746 ----
> {
> s++;
> name = s;
> +
> + /* 64 bit conditions. */
> + if (*args == 'A' && *s == '*')
> + s++;
> + else
> + break;
> +
You have to update NAME after skipping over the '*'. A minor goof, but it
will prevent you from doing any 64bit completers :-) I've fixed this in
your patch.
> ! static const char compare_cond_64_names[][6] = {
> ! ",*", ",*=", ",*<", ",*<=", ",*<<", ",*<<=", ",*sv", ",*od",
> ! ",*tr", ",*<>", ",*>=", ",*>", ",*>>=", ",*>>", ",*nsv", ",*ev"
> ! };
Instead of ",*" for the no condition case we should use an empty string. It's
awful weird to have to parse "add,*" and realize that it's just a simple
addition :-) I've fixed up that issue in a few places.
I made those fixes and install this patch + the follow-on bugfix you sent for
this patch.
Thanks,
jeff