This is the mail archive of the
binutils@sourceware.cygnus.com
mailing list for the binutils project.
Re: patch for 102785-CR-1
- To: Chandra Chavva <cchavva at cygnus dot com>
- Subject: Re: patch for 102785-CR-1
- From: Michael Meissner <meissner at cygnus dot com>
- Date: Fri, 11 Feb 2000 21:16:10 -0500
- Cc: binutils at sourceware dot cygnus dot com, gcc-patches at gcc dot gnu dot org
- References: <Pine.SOL.3.91.1000211162421.25073G-100000@canuck.cygnus.com>
On Fri, Feb 11, 2000 at 04:25:11PM -0800, Chandra Chavva wrote:
> Hi,
>
> The case 102785-CR-1 is mitsubishi d30v. This is want they want
>
> Here is an excerpt from the PR.
>
> >1. The combinations listed as follows are prohibited.
> > 1.1 Pararell executions
> > 1.1.1
> > MU: ST2W or ST4HB
> > IU: ADDHppp,SUBHppp, SATHp, SRC
>
> The correct rule is as follows.
>
> 1.1 Pararell executions
> 1.1.1
> MU: All the store instructions
> (STB,STH,STHH, STW,ST2W,ST4HB,ST2H)
> IU: ADDHppp,SUBHppp, SATHp, SRC
>
> We are sorry for our internal miscommunication.
>
> Here is the patch for it. Please let me know if the patch is fine or not.
I think it would be better if you either renamed FLAG_2WORD or added another
flag since the stores are not 2 word operations. Granted, the only use of
FLAG_2WORD is to prevent this optimization, but it leads to less confusion if
the flags are mnemonic.
--
Michael Meissner, Cygnus Solutions, a Red Hat company.
PMB 198, 174 Littleton Road #3, Westford, Massachusetts 01886, USA
Work: meissner@redhat.com phone: +1 978-486-9304
Non-work: meissner@spectacle-pond.org fax: +1 978-692-4482