This is the mail archive of the binutils@sourceware.cygnus.com mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]

Re: preparing for binutils 2.10


>>>>> Alan Modra writes:

Alan> On Thu, 9 Mar 2000, Alan Modra wrote:

>> On 9 Mar 2000, Andreas Jaeger wrote:
>> 
>> > Another problem is that I've got LANG set to german and therefore
>> > LC_COLLATE is different than expected.  Can we set LC_COLLATE to "C"
>> > for the tests (what's the best place to do so)?
>> 
>> ld/Makefile.am:check-DEJAGNU sets a number of vars for runtest.  Adding
>> LC_COLLATE=C there would be reasonable, similarly for other directories as
>> necessary.

Alan> That was a dumb comment.  Thinking one thing and saying another.  What I
Alan> should have said was:  See ld/Makefile.am:check-DEJAGNU for one place
Alan> where LC_COLLATE is already set (to empty).

Thanks for the hint.

Setting LC_COLLATE and LC_ALL is not enough, we need also to unset
LANG :-(.

With the appended patch and the one for testsuite/ld-elfvers/vers.exp,
make check runs without any problems on i686-linux.

Please apply the appended patch - and regenerate Makefile.in.


Andreas

2000-03-09  Andreas Jaeger  <aj@suse.de>

	* Makefile.am (check-DEJAGNU): Also unset LANG.


Index: ld/Makefile.am
===================================================================
RCS file: /cvs/src/src/ld/Makefile.am,v
retrieving revision 1.23
diff -u -r1.23 Makefile.am
--- Makefile.am	2000/02/29 19:52:31	1.23
+++ Makefile.am	2000/03/09 12:49:19
@@ -664,7 +664,7 @@
 check-DEJAGNU: site.exp
 	srcroot=`cd $(srcdir) && pwd`; export srcroot; \
 	r=`pwd`; export r; \
-	LC_COLLATE=; LC_ALL=; export LC_COLLATE LC_ALL; \
+	LC_COLLATE=; LC_ALL=; LANG=; export LC_COLLATE LC_ALL LANG; \
 	EXPECT=$(EXPECT); export EXPECT; \
 	if [ -f $(top_builddir)/../expect/expect ]; then \
 	  TCL_LIBRARY=`cd $(top_srcdir)/../tcl/library && pwd`; \

-- 
 Andreas Jaeger
  SuSE Labs aj@suse.de
   private aj@arthur.rhein-neckar.de

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]