Re: Patch for ppc _SDA_BASE_ value

[Momchil Velikov <velco at fadata dot bg>]

Geoff Keating wrote:
> 
> > Date: Thu, 30 Mar 2000 21:55:57 +0300
> > From: Momchil Velikov <velco@fadata.bg>
> 
> > Well, it's been almost a week with no feedback about this one ...
> >    http://sourceware.cygnus.com/ml/binutils/2000-03/msg00377.html
> 
> That's nothing.  If you have patches outstanding for more than six
> months, _then_ you should start to get worried.
:-))

> 
> Anyway, there are a few corner cases I'd like you to check:
> 
> - What happens if there are no .sdata or .sbss items at all, but the
>   _SDA_BASE_ symbol is still referenced?  Does it still have an
>   address corresponding to where .sdata sections would go if there
>   were any?
According to the ABIs, in this case _SDA_BASE_ should be set to zero.
The patch does not do this.

> - What happens when building a shared object?  Does the _SDA_BASE_
>   symbol still get created with the right value?
Again, ABIs say it shall have the same value as _GLOBAL_OFFSET_TABLE_.
The patch does not do this, too.

I'll fix these.

Regards,
-velco