Re: Symbol visibility revised

["Martin v. Loewis" <martin at loewis dot home dot cs dot tu-berlin dot de>]

> Here is the testcase. It failed with your patch.

I can't reproduce the failure:

mira% make
cc -S  -fPIC -O -B./ foo.c
echo ".hidden bar" >> foo.s
cc -O -B./ -c foo.s
cc -shared -o libfoo.so -O -B./ foo.o
cc -o foo -O -B./ libfoo.so main.c -Wl,-rpath,. -rdynamic
for f in foo; do echo "Running: $f"; ./$f; \
  if [ $? != 0 ]; then echo Failed; fi; done
Running: foo
Hello

I had to apply the following patch

--- orig/Makefile	Fri Apr  7 21:09:40 2000
+++ ./Makefile	Mon May  1 21:39:00 2000
@@ -13,7 +13,7 @@
 	$(CC) -shared -o $@ $(CFLAGS) $^
 
 foo.o: foo.s
-	$(CC) -c $^
+	$(CC) $(CFLAGS) -c $^
 
 foo.s: foo.c
 	$(CC) -S  -fPIC $(CFLAGS) $^

because it wouldn't use my modified assembler without it. Are you sure
you've used the patched utilities? FWIW, I first made the mistake of
not linking collect2 to ld in .

Regards,
Martin