This is the mail archive of the
binutils@sourceware.cygnus.com
mailing list for the binutils project.
Re: A patch for visibility.
On Tue, May 30, 2000 at 10:24:18AM +0200, Martin von Loewis wrote:
> > > I don't know what these are good for, and they eventually have to go,
> > > but I don't think we should break the tools on that target if there is
> > > no reason. Your patch would do that.
> >
> > This only means on V850 you will never be able to comply with the
> > current specs and never will have visibility.
>
> It means that and more: it means that binutils break the current usage
> of st_other on v850. I agree that it does not comply with the future
> revision of the gABI that is currently being drafted, it certainly
> complies with the *current* spec.
>
> I saw no reason to break these targets when I originally wrote the
> visibility code; I've also asked Cygnus for a position whether it
> would be acceptable to break them. If your position is an official
> Cygnus one (we don't care about breaking it and will find other
> solution), then that's fine with me. I just wanted to refute the claim
> that HJ's recent patch does not break anything - it does.
From my quick look, my patch shouldn't break anything since it clears
the visibility bits only for DSOs and executables. I don't believe
v850 uses st_other in either DSOs or executables.
H.J.