This is the mail archive of the
binutils@sourceware.cygnus.com
mailing list for the binutils project.
Re: bfd 2.10.90: Handle R_MIPS_REL32 relocations correctly
- To: "Maciej W. Rozycki" <macro at ds2 dot pg dot gda dot pl>
- Subject: Re: bfd 2.10.90: Handle R_MIPS_REL32 relocations correctly
- From: Alan Modra <alan at linuxcare dot com dot au>
- Date: Tue, 20 Jun 2000 10:09:24 +1000 (EST)
- cc: binutils at sourceware dot cygnus dot com, Ulf Carlsson <ulfc at engr dot sgi dot com>
On Mon, 19 Jun 2000, Maciej W. Rozycki wrote:
> * elf32-mips.c (_bfd_mips_elf_copy_indirect_symbol): New function.
> (elf_backend_copy_indirect_symbol): Map to the new function.
> Fix typos in comments.
What you're trying to achieve looks good to me, but why can't you just
copy possibly_dynamic_relocs and min_dyn_reloc_index across? Is it really
necessary to merge these fields? I know the generic code does this sort
of thing, but from my cursory inspection of elf32-mips.c, it seems like
the mips back-end will only update these values for the direct symbol.
Hmm, is it necessary to copy the fn_stub, need_fn_stub, call_stub and
call_fp_stub fields too?
Regards, Alan Modra
--
Linuxcare. Support for the Revolution.