This is the mail archive of the
binutils@sources.redhat.com
mailing list for the binutils project.
Re: Your patch breaks i386-pe gas
- To: hjl at valinux dot com
- Subject: Re: Your patch breaks i386-pe gas
- From: Ian Lance Taylor <ian at zembu dot com>
- Date: 16 Aug 2000 12:29:48 -0700
- CC: snowball3 at bigfoot dot com, nickc at cygnus dot com, binutils at sourceware dot cygnus dot com
- References: <20000816122309.A25775@valinux.com>
Date: Wed, 16 Aug 2000 12:23:09 -0700
From: "H . J . Lu" <hjl@valinux.com>
This patch breaks gas/testsuite/gas/all/cofftag.s under i386-pe:
../as-new -o dump.o /work/gnu/src/binutils/gas/testsuite/gas/all/cofftag.s
/work/build/gnu/bin/binutils/gas-ix86-pe/testsuite/../../binutils/objdump -t
dump.o > dump.out
regexp_diff match failure
regexp "^\[ 6\]\(sec -1\)\(fl 0x00\)\(ty b\)\(scl 16\) \(nx 0\) 0x0+0000
_operator$"
line "[ 6](sec -2)(fl 0x00)(ty b)(scl 16) (nx 0) 0x00000000 _operator"
regexp_diff match failure
regexp "^\[ 7\]\(sec -1\)\(fl 0x00\)\(ty b\)\(scl 16\) \(nx 0\) 0x0+0001
_flags$"
line "[ 7](sec -2)(fl 0x00)(ty b)(scl 16) (nx 0) 0x00000001 _flags"
regexp_diff match failure
regexp "^\[ 8\]\(sec -1\)\(fl 0x00\)\(ty 0\)\(scl 102\) \(nx 1\) 0x0+0004
.eos$"
line "[ 8](sec -2)(fl 0x00)(ty 0)(scl 102) (nx 1) 0x00000004 .eos"
FAIL: cofftag
I don't know COFF. If the patch is correct, could you please also fix
gas/testsuite/gas/all/cofftag.s and gas/testsuite/gas/all/cofftag.d?
2000-08-14 Mark Elbrecht <snowball3@bigfoot.com>
* config/obj-coff.c (obj_coff_endef) [BFD_ASSEMBLER]: Set the debug
flag for storage types C_ARG, C_REGPARM, C_FIELD, C_MOS, C_MOE,
C_MOU, and C_EOS.
I'm pretty sure that the cofftag test captures the way historical COFF
assemblers behave. So changing this would make gas different from
historical COFF assemblers. Whether that matters, I don't know.
Ian