Re: Patches for Borland TDS debugging info

[Troy Rollo <troy at rollo dot com>]

At 15:25 22/08/00 -0700, Nick Clifton wrote:
>: 1. I have added a new data element to the BFD structure -
>: "opened_for_symbols". TDS is a debugging only format which can
>: either be in the executable, or in a separate file. It should *only*
>: be recognised when a file is being opened to be read for debugging
>: symbols. A reader is expected to set this element to "true"
>: immediately after opening the file and before attempting to get BFD
>: to recognise the type of file.
>
>So where (in your patch) is this ever set to true ?

It isn't - the patch for GDB sets it to true.

>: 3. I have made no attempt to make TDS work in a heterogeneous remote
>: debugging environment.
>
>This might actually be the biggest problem, since everything else in the
>BFD has been designed to work in heterogenous environments.  I would
>strongly urge you to consider abandoning the ALIGNED1 macro and
>instead using external and internal versions of the structures in the
>same way that the ELF headers do.

If this is important I'd be more inclined to write a utility that used some 
method to programatically describe the data structures and generated code 
based on that - it might take longer but manually writing code to read in 
and convert an externalised structure seems incredibly wasteful of coding 
resources to me, and presumably such a utility could be reused to reduce 
this sort of grunt level coding in the future.

>Why is this entry "#if 0"ed out ?  The sparc entry is suppressed
>because it is not working yet, but I assume that (once your patch is
>applied) that the borland tds support will actually work.

I had interpreted that to be intended as a way of indicating that the 
vector is not designed to work in heterogeneous environments and should 
only be included if it's in SELECT_VECS.

>Oh - one other thing - please could you also add to your patch an
>update of binutils/NEWS saying that support for the TDS files has been
>added.

OK, Will do.

______________________________________________________________________________
troy@rollo.com				         Troy Rollo, Sydney, Australia
       Fight spam in Australia - Join CAUBE.AU - http://www.caube.org.au/