This is the mail archive of the binutils@sources.redhat.com mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]

Re: [PATCH] UnixWare Pentium III core file fix


On Thu, 28 Sep 2000, Petr Sorfa wrote:

> !   if (note->descsz == sizeof (pstatus_t)
> ! #if defined (HAVE_PXSTATUS_T)
> !       && note->descsz != sizeof (pxstatus_t)
> ! #endif
> !       )

This has got to be wrong.  Presumably you meant

          || note->descsz == sizeof (pxstatus_t)

Even ignoring this error, I'm not really happy with this patch.  What
guarantee do we have that pstatus_t and pxstatus_t will always have pr_pid
at the same offset?  I think it would be better to use a pxstatus_t local
variable and duplicate some code.  Same goes for lwpxstatus_t.

Alan Modra
-- 
Linuxcare.  Support for the Revolution.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]