This is the mail archive of the
binutils@sources.redhat.com
mailing list for the binutils project.
Re: [patch] pe-dll.c: Fix formatting (another one!)
- To: DJ Delorie <dj at delorie dot com>
- Subject: Re: [patch] pe-dll.c: Fix formatting (another one!)
- From: Alan Modra <alan at linuxcare dot com dot au>
- Date: Tue, 10 Oct 2000 02:31:56 +1100 (EST)
- cc: kazu at hxi dot com, binutils at sources dot redhat dot com
On Mon, 9 Oct 2000, DJ Delorie wrote:
>
> > > - /* Warning: the allocated symbols are remembered in BFD and reused
> > > - later, so don't free them! */
> > > - /* free (symbols); */
> >
> > You may as well delete the "free (symbols)" completely. Leaving code
> > commented out, or inside #if 0 .. #endif is really only useful if someone
> > might want to enable it in the future.
>
> Please leave the code the way I had it. Yes, I had a good reason for
> doing it that way, which the comment above it hints at. If you read
> the code preceeding that free, you'd think a free was required. If
> you put it in, you get a subtle crash much later in the linker.
> Leaving the commented out code and the comment there reminds me and
> future maintainers that the free may not happen there.
You snipped some of the context above. The comment is still there, which
should suffice.
> -} pe_details_type;
> +}
> +pe_details_type;
>
> I'm not too keen on these types of reformatting.
I'm inclined to agree with this one, but others will side with Kazu.
Was this change something indent did?
--
Linuxcare. Support for the Revolution.