This is the mail archive of the binutils@sources.redhat.com mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]

[RFA:] Adjust binutils-all/readelf.s to recent readelf.c formatting changes


The binutils testcase "readelf -S" was recently broken on many (all?)
32-bit targets due to readelf.c formatting changes.  Here's a patch to
fix the testcase.  I regex:ified the expected output slightly to try and
accommodate further tweaks in the last columns, but tried to keep most of
the readability.

Ok to commit?

	* binutils-all/readelf.s: Adjust to readelf.c formatting changes.

Index: readelf.s
===================================================================
RCS file: /cvs/src/src/binutils/testsuite/binutils-all/readelf.s,v
retrieving revision 1.3
diff -p -c -r1.3 readelf.s
*** readelf.s	2000/11/03 01:59:12	1.3
--- readelf.s	2000/11/28 01:18:23
*************** There are .* section headers, starting a
*** 2,21 ****
  
  Section Headers:
    \[Nr\] Name              Type            Addr     Off    Size   ES Flg Lk Inf Al
!   \[ 0\]                   NULL            00000000 000000 000000 00       0   0 0
!   \[ 1\] .text             PROGBITS        00000000 000034 000008 00  AX   0   0 .
!   \[ 2\] .rel.+text +REL. +0+ 0+.* 00000. 0.       .   1 4
  # MIPS targets put .rela.text here.
  #...
!   \[ .\] .data             PROGBITS        00000000 00003c 000004 00  WA   0   0 .
!   \[ .\] .bss              NOBITS          00000000 000040 000000 00  WA   0   0 .
  # MIPS targets put .reginfo and .mdebug here.
  # v850 targets put .call_table_data and .call_table_text here.
  #...
!   \[ .\] .shstrtab         STRTAB          00000000 0+.* 0+.* 00       0   0 .
!   \[ .\] .symtab           SYMTAB          00000000 0+.* 0+.* 10      ..   . 4
!   \[..\] .strtab           STRTAB          00000000 0+.* 0+.* 00       0   0 1
! Key to Flags: W \(write\), A \(alloc\), X \(execute\), M \(merge\), S \(strings\)
!               I \(info\), L \(link order\), O \(extra OS processing required\)
!               o \(os specific\), p \(processor specific\) x \(unknown\)
  
--- 2,22 ----
  
  Section Headers:
    \[Nr\] Name              Type            Addr     Off    Size   ES Flg Lk Inf Al
!   \[ 0\]                   NULL            00000000 000000 000000 00 +0 +0 +0
!   \[ 1\] .text             PROGBITS        00000000 000034 000008 00 +AX +0 +0 +.
!   \[ 2\] .rel.+text +REL. +0+ 0+.* 00000. 0. +. +1 +4
  # MIPS targets put .rela.text here.
  #...
!   \[ .\] .data             PROGBITS        00000000 00003c 000004 00  WA +0 +0 +.
!   \[ .\] .bss              NOBITS          00000000 000040 000000 00  WA +0 +0 +.
  # MIPS targets put .reginfo and .mdebug here.
  # v850 targets put .call_table_data and .call_table_text here.
  #...
!   \[ .\] .shstrtab         STRTAB          00000000 0+.* 0+.* 00 +0 +0 +.
!   \[ .\] .symtab           SYMTAB          00000000 0+.* 0+.* 10 +.. +. +4
!   \[..\] .strtab           STRTAB          00000000 0+.* 0+.* 00 +0 +0 +1
! Key to Flags:
!   W \(write\), A \(alloc\), X \(execute\), M \(merge\), S \(strings\)
!   I \(info\), L \(link order\), G \(group\), x \(unknown\)
!   O \(extra OS processing required\) o \(OS specific\), p \(processor specific\)
  
brgds, H-P

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]