This is the mail archive of the
binutils@sources.redhat.com
mailing list for the binutils project.
[patch] to ld: revert formatting change breaking K&R C preprocessor
- To: binutils at sources dot redhat dot com
- Subject: [patch] to ld: revert formatting change breaking K&R C preprocessor
- From: msokolov at ivan dot Harhan dot ORG (Michael Sokolov)
- Date: Tue, 12 Dec 00 22:55:45 PST
Nick,
I know you like beautifying and fixing formatting in binutils code, but your
last innocent-looking beautification change to ld/ldlang.c:
: revision 1.35
: date: 2000/11/30 19:30:32; author: nickc; state: Exp; lines: +6 -8
: Add support for x86_64-*-linux-gnu* target
breaks the K&R C preprocessor. The patch below reverts the offending change.
--
Michael Sokolov
Public Service Agent
International Engineering and Science Task Force
1351 VINE AVE APT 27 Phone: +1-714-738-5409
FULLERTON CA 92833-4291 USA (home office)
E-mail: msokolov@ivan.Harhan.ORG (ARPA TCP/SMTP)
Tue Dec 12 22:45:58 PST 2000 Michael Sokolov <msokolov@ivan.Harhan.ORG>
* ldlang.c (new_stat): Revert the last beautification with "innocent"
whitespace, it breaks the K&R C preprocessor.
Index: ldlang.c
===================================================================
RCS file: /cvs/src/src/ld/ldlang.c,v
retrieving revision 1.35
diff -p -r1.35 ldlang.c
*** ldlang.c 2000/11/30 19:30:32 1.35
--- ldlang.c 2000/12/13 06:47:48
*************** etree_type *base; /* Relocation base - o
*** 195,201 ****
#define cat(a,b) a/**/b
#endif
! #define new_stat(x, y) (cat (x, _type)*) new_statement (cat (x, _enum), sizeof (cat (x, _type)), y)
#define outside_section_address(q) ((q)->output_offset + (q)->output_section->vma)
--- 195,203 ----
#define cat(a,b) a/**/b
#endif
! /* Don't beautify the line below with "innocent" whitespace, it breaks the K&R
! C preprocessor! */
! #define new_stat(x,y) (cat(x,_type)*) new_statement(cat(x,_enum), sizeof(cat(x,_type)),y)
#define outside_section_address(q) ((q)->output_offset + (q)->output_section->vma)