This is the mail archive of the binutils@sources.redhat.com mailing list for the binutils project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]

Re: A patch for elflink.h

To: "H . J . Lu" <hjl at lucon dot org>
Subject: Re: A patch for elflink.h
From: amodra at one dot net dot au
Date: Mon, 30 Apr 2001 14:00:45 +0930
Cc: binutils at sourceware dot cygnus dot com
References: <20010427103121.A6940@lucon.org> <20010427114620.A8342@lucon.org>

On Fri, Apr 27, 2001 at 11:46:20AM -0700, H . J . Lu wrote:
> 
> The above patch won't work for hppa. Here is a new one. Any comments?
> I'd like to chek it in today.

I can't see anything wrong with this patch, so please check it in.

My only comment is that it's messy to be playing with
ELF_LINK_FORCED_LOCAL inside the .._hide_symbol functions.  I guess
the problem is really that hide_symbol is trying to do two different
things, removing plt entries, and removing dynamic symbols.  If we
changed hide_symbol to just handle the plt entry removal (which is
the part that is target dependent), then the messy bits would go away.

Alan

References:
- A patch for elflink.h
  - From: H . J . Lu
- Re: A patch for elflink.h
  - From: H . J . Lu

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]