This is the mail archive of the
binutils@sources.redhat.com
mailing list for the binutils project.
Re: [patch] objdump architecture list
- To: Matthias Kramm <matthias dot kramm at stud dot tu-muenchen dot de>
- Subject: Re: [patch] objdump architecture list
- From: Alan Modra <amodra at bigpond dot net dot au>
- Date: Sun, 29 Jul 2001 15:01:55 +0930
- Cc: binutils at sourceware dot cygnus dot com
- References: <20010728233506.A1908@stud.tu-muenchen.de>
On Sat, Jul 28, 2001 at 11:35:52PM +0200, Matthias Kramm wrote:
> Index: ChangeLog
> ===================================================================
> RCS file: /cvs/src/src/binutils/ChangeLog,v
> retrieving revision 1.313
> diff -u -r1.313 ChangeLog
> --- ChangeLog 2001/07/25 15:25:11 1.313
> +++ ChangeLog 2001/07/28 21:13:47
> @@ -1,3 +1,9 @@
> +2001-07-28 Matthias Kramm <kramm@quiss.org>
> +
> + * objdump.c: (usage) Show supported architectures along with
> + supported targets
> + * bucomm.c, bucomm.h: Introduce function list_supported_architectures
> +
It's better to provide a ChangeLog entry as plain text, not a diff.
ChangeLogs often change so quickly that a diff won't apply.
> + for (arch = bfd_arch_list(); *arch; arch++)
> + {
> + fprintf (f, " %s", *arch);
> + }
Write "bfd_arch_list ()". Also, the brace have the wrong indentation.
No need to resubmit this patch; I've applied it. The corrections are
for future patches. :)
Alan