Re: Fix for s390_elf_cons.

[Andreas Jaeger <aj at suse dot de>]

Alan Modra <amodra@bigpond.net.au> writes:

> On Tue, Aug 07, 2001 at 01:41:00PM +0200, Andreas Jaeger wrote:
> > "Martin Schwidefsky" <schwidefsky@de.ibm.com> writes:
>> 
>> > Hi,
>> > Andreas complained that binutils-2.11.90.0.24 doesn't work on s390/s390x.
>> > Well he is right. The problem is that the behaviour of fixup_segment has
>> > changed a bit.  The solution is to pass false for pcrel on the call to
>> > fix_new_exp in s390_elf_cons. Then the missing pc relative conversion in
>> > fixup_segment are done again.
>> 
>> Has this issue now been resolved?  I didn't see the patch committed
>> and from the discussion it's not clear to me what should be done now.
>
> Since I was involved in the discussion, let me make it clear that I don't
> have an objection to the patch itself.  It's OK to commit in that it does
> the right thing interpreting the, to my mind weird, s390 assembly syntax.
> I suppose it's too late to change the syntax now.

In that case: Martin, shall I commit the patch?

Thanks Alan,
Andreas
-- 
 Andreas Jaeger
  SuSE Labs aj@suse.de
   private aj@arthur.inka.de
    http://www.suse.de/~aj

PGP signature