This is the mail archive of the binutils@sources.redhat.com mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]

Re: Why pass HAVE_32BIT_GPRS to OPCODE_IS_MEMBER?


Eric Christopher wrote:
> 
> > Same here.  Is the patch below OK?  It uses "addu" instead of "or" with
> > -mgp32 and -mabi=32.  Can change it to use "or" if the concensus is that
> > that's safer.
> > 
> 
> I usually prefer or, but at this point I think it is an aesthetic
> preference :)

It's not only aesthetics, some CPU's can issue 2 'addu' at the same
time but only one 'or'.

> Anyhow, this looks ok to me.

Same here. In review the INSN_GP32 looked weird amongst the
processor specific defines.


Thiemo


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]