This is the mail archive of the binutils@sources.redhat.com mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]

Re: PATCH: Add bfd_sprintf_vma/bfd_fprintf_vma


On Fri, Aug 10, 2001 at 10:11:20AM +0200, Maciej W. Rozycki wrote:
> On Thu, 9 Aug 2001, H . J . Lu wrote:
> 
> > +void
> > +bfd_sprintf_vma (abfd, buf, value)
> > +     bfd *abfd;
> > +     char *buf;
> > +     bfd_vma value;
> > +{
> > +  if (bfd_get_flavour (abfd) == bfd_target_elf_flavour)
> > +    return bfd_elf_sprintf_vma (abfd, buf, value);
>        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
> > +  sprintf_vma (buf, value);
> > +}
> 
>  I don't think returning a value from a void function is the cleanest idea
> ever.  Otherwise, I'll check the changes when my time permits.  Thanks. 

Fixed.


H.J.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]