Re: [PATCH] Support -z combreloc in binutils

[Andreas Jaeger <aj at suse dot de>]

Jakub,

I tested the patch on i686-linux with current CVS.  The patch itself
passed the testsuite but then I changed ldmain.c to always use
combreloc:
  link_info.combreloc = true;

Now I get lots of test failures in the ld testsuite:
                === ld Summary ===

# of expected passes            92
# of unexpected failures        14
# of expected failures          1

$ grep -B1 FAIL ld.log 
child killed: segmentation violation
FAIL: visibility (hidden_normal) (non PIC)
--
child killed: segmentation violation
FAIL: visibility (hidden_normal) (PIC main, non PIC so)
--
child killed: segmentation violation
FAIL: visibility (hidden_weak) (non PIC)
--
child killed: segmentation violation
FAIL: visibility (hidden_weak) (PIC main, non PIC so)
--
child killed: segmentation violation
FAIL: visibility (protected) (non PIC)
--
child killed: segmentation violation
FAIL: visibility (protected) (PIC main, non PIC so)
--
child killed: segmentation violation
FAIL: visibility (protected_undef_def) (non PIC)
--
child killed: segmentation violation
FAIL: visibility (protected_undef_def) (PIC main, non PIC so)
--
child killed: segmentation violation
FAIL: visibility (protected_weak) (non PIC)
--
child killed: segmentation violation
FAIL: visibility (protected_weak) (PIC main, non PIC so)
--
child killed: segmentation violation
FAIL: visibility (normal) (non PIC)
--
child killed: segmentation violation
FAIL: visibility (normal) (PIC main, non PIC so)
--
selective6: A::foo() == nm_output(A::foo(void))
XFAIL: selective6
--
child killed: segmentation violation
FAIL: shared (non PIC)
--
child killed: segmentation violation
FAIL: shared (PIC main, non PIC so)

It looks like -z combreloc is either broken - or will not work with an
unpatched glibc 2.2.2,

Andreas
-- 
 Andreas Jaeger
  SuSE Labs aj@suse.de
   private aj@arthur.inka.de
    http://www.suse.de/~aj