This is the mail archive of the
binutils@sources.redhat.com
mailing list for the binutils project.
Re: [patch] *-dis.c: Fix formatting.
- To: Andrew Cagney <ac131313 at cygnus dot com>
- Subject: Re: [patch] *-dis.c: Fix formatting.
- From: Alan Modra <amodra at bigpond dot net dot au>
- Date: Sat, 18 Aug 2001 14:58:47 +0930
- Cc: Kazu Hirata <kazu at hxi dot com>, binutils at sources dot redhat dot com
- References: <200108171934.MAA23915@cygnus.com> <3B7DF02F.90201@cygnus.com>
On Sat, Aug 18, 2001 at 12:33:51AM -0400, Andrew Cagney wrote:
> > @@ -22,9 +22,7 @@
> > #include "dis-asm.h"
> > #include "opintl.h"
> >
> > -
> > -struct avr_opcodes_s
> > -{
> > +struct avr_opcodes_s {
> > char *name;
> > char *constraints;
> > char *opcode;
>
>
> While I'm not sure what BINUTILS is doing I would note that the GNU
> Coding Standard recomments:
>
> struct foo
> {
> char *name;
> char *consts;
> };
>
> as controlled by gnu-indent's -bls.
Oh?
http://www.gnu.org/prep/standards_23.html#SEC24
"It is important to put the open-brace that starts the body of a C
function in column zero, and avoid putting any other open-brace or
open-parenthesis or open-bracket in column zero. Several tools look
for open-braces in column zero to find the beginnings of C functions.
These tools will not work on code not formatted that way."