This is the mail archive of the
binutils@sources.redhat.com
mailing list for the binutils project.
Re: Problem with -f option and #APP
- To: "J. Johnston" <jjohnstn at cygnus dot com>
- Subject: Re: Problem with -f option and #APP
- From: Alan Modra <amodra at bigpond dot net dot au>
- Date: Wed, 26 Sep 2001 09:31:09 +0930
- Cc: binutils at sources dot redhat dot com
- References: <3BAFA0EB.F427624F@cygnus.com>
On Mon, Sep 24, 2001 at 05:08:59PM -0400, J. Johnston wrote:
>
> Ok to check in?
Yes, seems reasonable to me. You didn't include a ChangeLog entry with
your patch. Please ensure you add a ChangeLog entry when committing, and
also fix the formatting nits.
> Index: gas/input-file.c
> ===================================================================
> RCS file: /cvs/src/src/gas/input-file.c,v
> retrieving revision 1.7
> diff -u -r1.7 input-file.c
> --- gas/input-file.c 2001/08/01 01:44:25 1.7
> +++ gas/input-file.c 2001/09/24 21:00:35
> @@ -159,10 +159,20 @@
> if (c == 'N')
> {
> fgets (buf, 80, f_in);
> - if (!strcmp (buf, "O_APP\n"))
> + if (!strncmp (buf, "O_APP", 5) && isspace(buf[5]))
Space before open parenthesis.
> preprocess = 0;
> if (!strchr (buf, '\n'))
> ungetc ('#', f_in); /* It was longer. */
> + else
> + ungetc ('\n', f_in);
> + }
> + else if (c == 'A')
> + {
> + fgets (buf, 80, f_in);
> + if (!strncmp (buf, "PP", 2) && isspace(buf[2]))
Same here.
> + preprocess = 1;
> + if (!strchr (buf, '\n'))
> + ungetc ('#', f_in);
> else
> ungetc ('\n', f_in);
> }