This is the mail archive of the
binutils@sources.redhat.com
mailing list for the binutils project.
Re: GAS patch for sh*-unknown-linux-gnu
- To: NIIBE Yutaka <gniibe at m17n dot org>
- Subject: Re: GAS patch for sh*-unknown-linux-gnu
- From: Hans-Peter Nilsson <hp at bitrange dot com>
- Date: Thu, 4 Oct 2001 06:17:37 -0400 (EDT)
- cc: <binutils at sources dot redhat dot com>
Thank you for your patch. One quick note.
On Wed, 3 Oct 2001, NIIBE Yutaka wrote:
> Index: gas/config/tc-sh.c
> +big (ignore)
> + int ignore ATTRIBUTE_UNUSED;
> +{
> + target_big_endian = 1;
> +}
> + {"big", big, 0},
Setting the endianness from a directive will not work. The
output file already has been opened and the endianness set at
the time the directive is processed. Changing it to be an
assertion (with an as_bad call if the output isn't big-endian)
might be useful, though.
I'm not against the rest of the patch (as long as it doesn't
affect compatibility), but will unfortunately not have time to
look closer until after this weekend. (The same goes for the
other pending SH patches. Sorry.) I'll consider the comments
this patch has received when I review it properly.
brgds, H-P