This is the mail archive of the
binutils@sources.redhat.com
mailing list for the binutils project.
Re: Patch to ld/pe-dll.c: Use explicit lookup for filering excluded objects
- To: Danny Smith <danny_r_smith_2001 at yahoo dot co dot nz>
- Subject: Re: Patch to ld/pe-dll.c: Use explicit lookup for filering excluded objects
- From: Charles Wilson <cwilson at ece dot gatech dot edu>
- Date: Thu, 18 Oct 2001 01:39:52 -0400
- CC: DJ Delorie <dj at delorie dot com>, binutils at sources dot redhat dot com
- References: <20011017094700.44409.qmail@web14501.mail.yahoo.com>
Danny Smith wrote:
>>And would we need the lengths in the table still, with this patch?
>>
>
> No. Nor does autofilter_symbollist. I have changed both to simple arrays of
> char* and calculated fixed array length once at file level.
>
> Revised patch tested on mingw32.
Sigh. I'm not as enthusiastic about this change. dunno why, call it
stylistic, but I liked the parallelism of the five loops, and using the
same data structures for each list. Also, the addition of yet more
static variables (even if they are auto-calculated) just seems hackish,
compared to the standard "loop until NULL" structure that was in use
before. This to me seems to be a stylistic regression. But it *will*
work, so I can't object to it on practical grounds.
Or maybe I'm just being overly paternalistic to my own code. <g>
--Chuck