This is the mail archive of the
binutils@sources.redhat.com
mailing list for the binutils project.
Re: [Fwd: [patch][rfa]: Decoding insns > 32 bits in length] - Opinion requested from Nick Clifton
- To: Dave Brolley <brolley at redhat dot com>
- Subject: Re: [Fwd: [patch][rfa]: Decoding insns > 32 bits in length] - Opinion requested from Nick Clifton
- From: Nick Clifton <nickc at cambridge dot redhat dot com>
- Date: 07 Nov 2001 15:13:17 +0000
- Cc: cgen at sources dot redhat dot com, binutils at sources dot redhat dot com
- References: <3BE8341D.1040800@redhat.com>
Hi Dave,
> I was asked to ask you about the patch to opcodes/cgen-ibld.in
> below. It was suggested that you had added the #if 0 a short while
> ago.
I do not remmeber doing that, but I think that it is probably very
likely that I did. (I was patching lots of things at the time, trying
to remove all the compile time warnings).
> Did you intend to remove the call to cgen_get_insn_value?
No, that was definitely a SNAFU.
> Putting it back solves problems for a number of different ports.
Agreed. Do you want me to do this or will you ?
> - #if 0
> - int big_p = CGEN_CPU_INSN_ENDIAN (cd) == CGEN_ENDIAN_BIG;
> -
> x = cgen_get_insn_value (cd, bufp, word_length);
> - #endif
Note - the definition and use of big_p is still redundant.
Cheers
Nick