This is the mail archive of the
binutils@sources.redhat.com
mailing list for the binutils project.
Re: i386 gas is broken
- From: Alan Modra <amodra at bigpond dot net dot au>
- To: "H . J . Lu" <hjl at lucon dot org>
- Cc: binutils at sourceware dot cygnus dot com
- Date: Thu, 15 Nov 2001 18:09:59 +1030
- Subject: Re: i386 gas is broken
- References: <20011114232118.A2574@lucon.org>
On Wed, Nov 14, 2001 at 11:21:18PM -0800, H . J . Lu wrote:
> i386 gas is broken. Today's CVS configured with
It's more than just x86 gas.
bfd/ChangeLog
* elflink.h (elf_reloc_symbol_deleted_p): Don't try to swap in
external syms.
Index: bfd/elflink.h
===================================================================
RCS file: /cvs/src/src/bfd/elflink.h,v
retrieving revision 1.124
diff -u -p -r1.124 elflink.h
--- elflink.h 2001/11/15 01:34:10 1.124
+++ elflink.h 2001/11/15 07:38:08
@@ -7786,9 +7782,9 @@ elf_reloc_symbol_deleted_p (offset, cook
if (rcookie->rel->r_offset != offset)
continue;
- if (rcookie->locsyms)
+ if (rcookie->locsyms && r_symndx < rcookie->locsymcount)
elf_swap_symbol_in (rcookie->abfd,
- ((Elf_External_Sym *)rcookie->locsyms) + r_symndx,
+ (Elf_External_Sym *) rcookie->locsyms + r_symndx,
&isym);
if (r_symndx >= rcookie->locsymcount