This is the mail archive of the
binutils@sources.redhat.com
mailing list for the binutils project.
Re: i386 gas is broken
On Thu, Nov 15, 2001 at 06:09:59PM +1030, Alan Modra wrote:
> On Wed, Nov 14, 2001 at 11:21:18PM -0800, H . J . Lu wrote:
> > i386 gas is broken. Today's CVS configured with
>
> It's more than just x86 gas.
>
> bfd/ChangeLog
> * elflink.h (elf_reloc_symbol_deleted_p): Don't try to swap in
> external syms.
H.J.,
What do you say about the following?
* elflink.h (elf_link_input_bfd): Complain about all relocs against
local syms from discarded sections, not just the section sym.
I'm building x86 binutils with this and the above at the moment..
Alan
Index: bfd/elflink.h
===================================================================
RCS file: /cvs/src/src/bfd/elflink.h,v
retrieving revision 1.124
diff -u -p -w -r1.124 elflink.h
--- elflink.h 2001/11/15 01:34:10 1.124
+++ elflink.h 2001/11/15 07:43:36
@@ -6343,9 +6343,6 @@ elf_link_input_bfd (finfo, input_bfd)
}
else
{
- isym = finfo->internal_syms + r_symndx;
- if (ELF_ST_TYPE (isym->st_info) == STT_SECTION)
- {
asection *sec = finfo->sections[r_symndx];
if (sec != NULL
@@ -6394,7 +6391,6 @@ elf_link_input_bfd (finfo, input_bfd)
}
}
}
- }
/* Relocate the section by invoking a back end routine.