This is the mail archive of the binutils@sources.redhat.com mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Delete bfd/po/{SRC,BLD}-POTFILES.in from CVS?


Hi Andrew,

> Should the files
> 
> 	bfd/po/SRC-POTFILES.in
> 	bfd/po/BLD-POTFILES.in
> 
> be removed from CVS?  When configuring in the src directory (something
> the release process does) `make distclean` deletes them.

I'm with Alan on this:

: From: Alan Modra <amodra@bigpond.net.au>
: 
: I think this belongs on mainline too.  It's consistent with the
: treatment of po/POTFILES.in for other dirs.

> Should `make distclean` delete the files:
> 
> 	bfd/po/SRC-POTFILES.in
> 	bfd/po/BLD-POTFILES.in
> 
> Given a distro without those files, a normal make will regenerate them
> but in the SRC directory.  Unfortunately the src directory can be
> read-only.

Right, so how about the patch below ?  With it applied, the files will
only be deleted for a "make distclean" run with
--enable-maintainer-mode.  And presumably maintainers have the tools,
and the write-enabled file systems, to recreate these files.

Note - as it turns out, even maintainers will not be able to delete
these files by running "make distclean" as this comment in the Make-in
file explains:

  # Note - The presence of SRC-POTFILES and BLD-POTFILES as dependencies
  # here breaks the implementation of the 'distclean' rule for maintainers.
  # This is because if 'make distclean' is run in the BFD directory, the
  # Makefile there will be deleted before 'distclean' is made here, and so
  # the dependency SRC-POTFILES -> SRC-POTFILES.in -> ../Makefile cannot
  # be satisfied.
  #
  # The SRC-POTFILES and BLD-POTFILES dependencies cannot be removed,
  # however since it is necessary that these files be built during
  # *configure* time, so that configure can insert them into the
  # po/Makefile that it is creating, so that the Makefile will have
  # the correct dependencies.

I am not sure if there is anything that can be done about this...

Cheers
        Nick


2001-11-19  Nick Clifton  <nickc@cambridge.redhat.com>

	* po/Make-in (distclean): Only delete SRC-POTFILES.in and
	BLD-POTFILES.in if you are a maintainer.

Index: bfd/po/Make-in
===================================================================
RCS file: /cvs/src/src/bfd/po/Make-in,v
retrieving revision 1.3
diff -p -r1.3 Make-in
*** Make-in	2001/06/10 05:21:00	1.3
--- Make-in	2001/11/19 16:02:31
*************** clean: mostlyclean
*** 205,211 ****
  
  distclean: clean
  	rm -f Makefile Makefile.in *.mo *.msg *.cat *.cat.m
! 	rm -f SRC-POTFILES BLD-POTFILES SRC-POTFILES.in	BLD-POTFILES.in
  
  maintainer-clean: distclean
  	@echo "This command is intended for maintainers to use;"
--- 205,211 ----
  
  distclean: clean
  	rm -f Makefile Makefile.in *.mo *.msg *.cat *.cat.m
! 	rm -f SRC-POTFILES BLD-POTFILES @MAINT@ SRC-POTFILES.in	BLD-POTFILES.in
  
  maintainer-clean: distclean
  	@echo "This command is intended for maintainers to use;"


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]