This is the mail archive of the binutils@sources.redhat.com mailing list for the binutils project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] Various source cleanup/enhancements

From: Alan Modra <amodra at bigpond dot net dot au>
To: Eric Christopher <echristo at redhat dot com>
Cc: Thiemo Seufer <ica2_ts at csv dot ica dot uni-stuttgart dot de>, binutils at sources dot redhat dot com
Date: Tue, 4 Dec 2001 08:27:28 +1030
Subject: Re: [PATCH] Various source cleanup/enhancements
References: <20011203103725.N487@rembrandt.csv.ica.uni-stuttgart.de> <1007416024.1421.1.camel@ghostwheel.cygnus.com>

On Mon, Dec 03, 2001 at 01:47:04PM -0800, Eric Christopher wrote:
> Ok except for these.  Make sure they are capitals before checking in :)

Err, the standard (from gcc) for error messages is as Thiemo had it.
This text is prefixed with "Error: " so it doesn't start a sentence, and
thus should not start with a capital.

> > @@ -11565,7 +11736,7 @@ s_mips_weakext (ignore)
> >      {
> >        if (S_IS_DEFINED (symbolP))
> >  	{
> > -	  as_bad ("Ignoring attempt to redefine symbol `%s'.",
> > +	  as_bad ("ignoring attempt to redefine symbol %s",

Follow-Ups:
- Re: [PATCH] Various source cleanup/enhancements
  - From: Eric Christopher

References:
- [PATCH] Various source cleanup/enhancements
  - From: Thiemo Seufer
- Re: [PATCH] Various source cleanup/enhancements
  - From: Eric Christopher

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]