Re: patch, ldemul_choose_target, AIX -b64 support

[Alan Modra <amodra at bigpond dot net dot au>]

On Mon, Dec 03, 2001 at 05:07:03PM -0600, Tom Rix wrote:
> Alan Modra wrote:
> 
> >
> > Space before open parenthesis.
> 
> Space's added...
> 
> >
> > > + static char *
> > > + choose_target (argc, argv)
> > > +      int argc;
> > > +      char **argv;
> > > + {
> > > +   int i, j, jmax;
> > > +   static char *from_outside;
> > > +   static char *from_inside;
> > > +   static char *argv_to_target[][2] =
> > > +     {
> > > +       NULL,   "aixcoff-rs6000",
> > > + #ifdef _AIX43
> > > +       "-b32", "aixcoff-rs6000",
> > > +       "-b64", "aixcoff64-rs6000",
> > > + #endif
> > > +     };
> > > +
> > > +   jmax = 1;
> > > + #ifdef _AIX43
> > > +   jmax = 3;
> > > + #endif
> >
> > Why the #ifdefs here?  Think cross-tools.
> 
> Mmmm.  No the ifdef's aren't needed.
> deleting...

OK to apply then.  If you find a spare moment, please take a look at
bringing aix.em into compliance with the GNU coding standards.  I
noticed a number of cases in your patch where '{'s were not on a
separate line but decided not to complain at the time.  eg.

    if (0 == strcmp(input, string)) {
      if (1 << bit & ${SYSCALL_MASK}) {
	*flag = s[bit].flag;
	return 1;
      } else {
	return 0;
      }

should be

    if (0 == strcmp (input, string))
      {
	if (1 << bit & ${SYSCALL_MASK})
	  {
	    *flag = s[bit].flag;
	    return 1;
	  }
	else
	  {
	    return 0;
	  }
      }