This is the mail archive of the
binutils@sources.redhat.com
mailing list for the binutils project.
Re: usage of disassemble_info variables
- From: Ian Lance Taylor <ian at airs dot com>
- To: Doug Evans <dje at transmeta dot com>
- Cc: binutils at sourceware dot cygnus dot com
- Date: 06 Dec 2001 11:42:24 -0800
- Subject: Re: usage of disassemble_info variables
- References: <200112061844.KAA14540@casey.transmeta.com>
Doug Evans <dje@transmeta.com> writes:
> There seems to be an unwritten rule that a disassemble_info
> variable can't be a (non-static) local variable.
> Either that or INIT_DISASSEMBLE_mumble must initialize disassembler_options
> or each caller to print_insn_i386* is responsible for setting it.
>
> We have various entry points into the x86 disassembler
> and I'm seeing a segv'ing because disassembler_options has garbage.
>
> objdump initializes it.
> gdb doesn't but gets away with it because tm_print_insn_info is a global.
>
> What's up?
I think that INIT_DISASSEMBLE_* should always be called on an instance
of disassembler_options before it is used. From dis-asm.h:
/* Macro to initialize a disassemble_info struct. This should be called
by all applications creating such a struct. */
I think this applies whether the disassembler_options is global,
static, or local. If gdb doesn't initialize it, it should.
Ian