This is the mail archive of the binutils@sources.redhat.com mailing list for the binutils project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] Fix strip bug with SHF_MERGE sections

From: Jakub Jelinek <jakub at redhat dot com>
To: Richard Henderson <rth at redhat dot com>
Cc: binutils at sources dot redhat dot com
Date: Sun, 9 Dec 2001 16:28:55 -0500
Subject: Re: [PATCH] Fix strip bug with SHF_MERGE sections
References: <20011208225949.C2651@sunsite.ms.mff.cuni.cz> <20011208190716.A16973@redhat.com> <20011209123936.D2651@sunsite.ms.mff.cuni.cz> <20011209110114.C22878@redhat.com>
Reply-to: Jakub Jelinek <jakub at redhat dot com>

On Sun, Dec 09, 2001 at 11:01:14AM -0800, Richard Henderson wrote:
> On Sun, Dec 09, 2001 at 12:39:36PM +0100, Jakub Jelinek wrote:
> > I agree that it can be copied unconditionally, just SEC_MERGE needs to be
> > cleared if the input section was not SEC_MERGE (flags can change e.g.
> > because of section rename options).
> 
> Err.. I don't understand.  Why would a rename change flags?

--rename-section OLDNAME=NEWNAME[,FLAGS]

But currently merge nor strings is not accepted as flags there anyway, so it
doesn't matter (and if it is ever accepted, parse_flags and other routines
would need to be changed to propagate new entity size anyway).
So I'll leave just osection->entsize = isection->entsize;, ok?

	Jakub

Follow-Ups:
- Re: [PATCH] Fix strip bug with SHF_MERGE sections
  - From: Richard Henderson

References:
- [PATCH] Fix strip bug with SHF_MERGE sections
  - From: Jakub Jelinek
- Re: [PATCH] Fix strip bug with SHF_MERGE sections
  - From: Richard Henderson
- Re: [PATCH] Fix strip bug with SHF_MERGE sections
  - From: Jakub Jelinek
- Re: [PATCH] Fix strip bug with SHF_MERGE sections
  - From: Richard Henderson

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]