This is the mail archive of the
binutils@sources.redhat.com
mailing list for the binutils project.
Re: [RFA] Don't sort PT_NOTE sections.
- From: Alan Modra <amodra at bigpond dot net dot au>
- To: Michael Snyder <msnyder at cygnus dot com>
- Cc: binutils at sources dot redhat dot com, nickc at redhat dot com
- Date: Tue, 18 Dec 2001 13:59:57 +1030
- Subject: Re: [RFA] Don't sort PT_NOTE sections.
- References: <200112122117.fBCLHFw16819@reddwarf.cygnus.com>
On Wed, Dec 12, 2001 at 01:17:15PM -0800, Michael Snyder wrote:
>
> asection **secpp;
>
> /* If elf_segment_map is not from map_sections_to_segments, the
> ! sections may not be correctly ordered. NOTE: do not sort
> ! sections of type PT_NOTE. */
> ! if (m->count > 1 && m->p_type != PT_NOTE)
> qsort (m->sections, (size_t) m->count, sizeof (asection *),
> elf_sort_sections);
Your comment change adds no information not immediately obvious in the
code. Also, I think it may be safer to restrict this change to core
files. ie. do sort for elf_elfheader (abfd)->e_type != ET_CORE
Alan