This is the mail archive of the binutils@sources.redhat.com mailing list for the binutils project.
Index Nav: | [Date Index] [Subject Index] [Author Index] [Thread Index] | |
---|---|---|
Message Nav: | [Date Prev] [Date Next] | [Thread Prev] [Thread Next] |
Other format: | [Raw text] |
On Tue, 2001-12-18 at 18:11, Hans-Peter Nilsson wrote: > On 18 Dec 2001, Nick Clifton wrote: > > Note - you did not include incbin.dat in the patch submission... Of Oops, so I did. > > course it is a binary file, but it could have been MIME encoded. > (Not that incbin.dat looks particularly binary, but:) > > Aren't we supposed to avoid binary "source" files. What would > update patches, like a binutils-2.11-2.12.diff.gz look like? Hmm, yes that's a problem. The windres tests do it and I believe there was a discussion about ASCII encoding the files and binifying them when running the tests. The only problem I see is that this test would fail on CRLF platforms (like cygwin text-mounts) since that would change the "binary" source file. Here's the patch + incbin.dat. If it's ok, please commit. -Anders
Attachment:
incbin-test.diff
Description: Text document
Attachment:
incbin.dat
Description: MPEG movie
Index Nav: | [Date Index] [Subject Index] [Author Index] [Thread Index] | |
---|---|---|
Message Nav: | [Date Prev] [Date Next] | [Thread Prev] [Thread Next] |