This is the mail archive of the binutils@sources.redhat.com mailing list for the binutils project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: off by one in bfd/syms.c or bfd/elfcode.h?

Gregory Steuck <greg@nest.cx> writes:

> >>>>> "Ian" == Ian Lance Taylor <ian@airs.com> writes:
> 
>     Ian> I would say that the bug is not in either of the functions you
>     Ian> mention, but rather in _bfd_elf_get_symtab_upper_bound.  It
>     Ian> does not correctly handle the case of symtab_hdr->sh_size == 0,
>     Ian> as it does not leave room for the trailing null entry.
> 
> Would this be a correct patch then? (against release 2.10, I think)

Looks about right to me.  Does it work?

Ian
Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]