This is the mail archive of the binutils@sources.redhat.com mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: PATCH: Fix visibility for MIPS (Re: 2 problems with ELF visibility)


On Mon, Apr 22, 2002 at 12:44:47PM -0700, H . J . Lu wrote:
> I am enclosing a patch here. Any comments?
> 
> 	* elfxx-mips.c (mips_elf_link_hash_entry): Add forced_local.
> 	(mips_elf_link_hash_newfunc): Initialize forced_local to false.
> 	(mips_elf_record_global_got_symbol): Call _bfd_mips_elf_hide_symbol
> 	to hide a global symbol.
> 	(_bfd_mips_elf_hide_symbol): Return if forced_local is true. Set
> 	forced_local to true. 

The idea seems reasonable, but why can't you use ELF_LINK_FORCED_LOCAL
instead of using a new flag?

-- 
Alan Modra
IBM OzLabs - Linux Technology Centre


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]