This is the mail archive of the
binutils@sources.redhat.com
mailing list for the binutils project.
Re: just a little nitpik in bfd
On Mon, May 20, 2002 at 06:02:44PM +0100, Nick Clifton wrote:
> Hi H.J.
>
> > If you believe you didn't introduce any new bugs, check it in. I
> > will fix the testcases if necessary. I know it can be quite tricky.
>
> Well there were 6 new failures in all (vers 6 & 15, ELF weak data
> first, last, first common & last common) which I felt were too many
> to ignore.
>
> If you like though, try applying this patch and then see if you can
> fix up the failures. I would love to know why changing the hashing
> algorithm is affecting the tests though. I would have thought that
> the algorithm was completely hidden inside BFD.
>
I don't believe your change is correct. I think the same hashing
algorithm is used in several places in binutils. Please do
# find -type f | xargs grep "<<[ \t]*17"
in binutils.
H.J.