This is the mail archive of the binutils@sources.redhat.com mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] nm size/value output fixes.


On Fri, May 24, 2002 at 10:17:38AM +0100, Nick Clifton wrote:

> One thing I would suggest is to add macros to access the fields in the
> symbol_info and extended_symbol_info structures, eg:
> 
> #define SYM_VALUE(sym)  (sym->sinfo->value)
> #define SYM_SIZE(sym)   (sym->ssize)
> 
> and then use them throughout the code.  That way if you do have to
> change the layout of the structures (eg because you find you have to
> move the ssize field into the _symbol_info struct) then you only have
> to change the accessor macro and not tons of lines of code.

You are, of course, correct. In the next few days I'll finish the patch,
following your guideline and applying the changes to all cases (bsd, sysv,
posix).

Thank you for your feedback.

Elias

-- 
http://gnewtellium.sourceforge.net			MP3 is not a crime.	


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]