This is the mail archive of the binutils@sources.redhat.com mailing list for the binutils project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH/RFA] Add sh5*-*-netbsd* and sh64*-*-netbsd* targets

On Mon, Jun 03, 2002 at 04:06:48PM -0400, Hans-Peter Nilsson wrote:

 > It seems that warning was overlooked when tc-sh64.h was merged
 > into the FSF binutils; MD_PCREL_FROM_SECTION was added to
 > tc-sh.h on 2001-09-30, and nobody noticed the warning since
 > tc-sh64.h was merged...  Your change is obviously correct.

Ok, I will check this one in separately.

 > IIUC, that means it's currently there only if that's what BFD is
 > explicitly configured for.  So if you use --enable-all-targets
 > it won't be listed in _bfd_target_vector[].  I think it should
 > be there, inside #ifdef BFD64.  If everything builds with
 > --enable-all-targets, I'd count it as obvious.

Ok, I'll address this after I check in the other bits.

 > Looks fine to me, except for some formatting issues 8-P with the
 > ChangeLog:

Ok, now that Daniel has clarified the which formats are acceptable (thanks,
Daniel :-), I'll tidy these up a bit and check it in.

Thanks.

-- 
        -- Jason R. Thorpe <thorpej@wasabisystems.com>
Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]