This is the mail archive of the
binutils@sources.redhat.com
mailing list for the binutils project.
Re: [Revised patch] Rework MIPS command-line handling
- From: Eric Christopher <echristo at redhat dot com>
- To: cgd at broadcom dot com
- Cc: Richard Sandiford <rsandifo at redhat dot com>, gcc-patches at gcc dot gnu dot org, binutils at sources dot redhat dot com, Thiemo Seufer <ica2_ts at csv dot ica dot uni-stuttgart dot de>, "Maciej W. Rozycki" <macro at ds2 dot pg dot gda dot pl>, "Mark D. Baushke" <mdb at gnu dot org>
- Date: 18 Jul 2002 16:31:04 -0700
- Subject: Re: [Revised patch] Rework MIPS command-line handling
- References: <wvnfzyodh02.fsf@talisman.cambridge.redhat.com><wvnofd46duh.fsf@talisman.cambridge.redhat.com> <yov5u1mwsr66.fsf@broadcom.com>
> I think I agree with you here...
>
>
I'll just sum up that I agree with Chris. He'll like that thought. :)
>
> I don't have time to read all of the diffs right now, or to read them
> deeply, but there are a couple of comments below.
>
>
> chris
> =======
> > # Other random stuff.
> >
> > + case ${cpu_type} in
> > + mips)
> > + # Set mips_cpu to the name of the default CPU.
> > + case ${target_cpu} in
> > + mips | mipsbe | mipseb | mipsle | mipsel | mips64 | mips64el)
> > + mips_cpu=from-abi
> > + ;;
> > + mipsisa32 | mipsisa32el)
> > + mips_cpu=mips32
> > + ;;
> > + mipsisa64 | mipsisa64el)
> > + mips_cpu=mips64
> > + ;;
> > + mipstx39 | mipstx39el)
> > + mips_cpu=r3900
> > + ;;
> > + mips64* | mipsisa64*)
> > + changequote(,)dnl
> > + mips_cpu=`echo $target_cpu | sed -e 's/[a-z]*64//' -e 's/el$//'`
> > + changequote([,])dnl
> > + ;;
>
> Why not do the same here for mipsisa32*? (OK, nothing uses it yet...
> 8-)
>
And, well, mips64 is different from mipsisa64...
> > + # Decide whether to generate 32-bit or 64-bit code by default.
> > + # Used to resolve -march=from-abi when an embedded ABI is selected.
> > + case ${target_cpu} in
> > + mips64* | mipsisa64*)
> > + mips_default_64bit=1
> > + ;;
> > + *)
> > + mips_default_64bit=0
> > + ;;
>
> Might be desirable to provide an easy, existing way/place to override
> this based on the OS in question.
Yup.
-eric
--
I will not grease the monkey bars