This is the mail archive of the
binutils@sources.redhat.com
mailing list for the binutils project.
Re: PATCH: Check undefined version
- From: Alan Modra <amodra at bigpond dot net dot au>
- To: "H. J. Lu" <hjl at lucon dot org>
- Cc: binutils at sources dot redhat dot com
- Date: Thu, 8 Aug 2002 10:56:57 +0930
- Subject: Re: PATCH: Check undefined version
- References: <20020807134043.A9106@lucon.org>
On Wed, Aug 07, 2002 at 01:40:43PM -0700, H. J. Lu wrote:
> I'd like to check in this patch to check symbols with undefine version.
The idea looks OK to me.
> + for (t = verdefs; t != NULL; t = t->next)
> + if (t->globals != NULL)
> + for (d = t->globals; d != NULL; d = d->next)
The "if" here is redundant.
> + if (!newh
Style. if (newh == NULL
> + if (newh
Again. if (newh != NULL
> + /* Check if all global versions have a definiton. */
> + all_defined = true;
> + for (t = verdefs; t != NULL; t = t->next)
> + if (t->globals != NULL)
> + for (d = t->globals; d != NULL; d = d->next)
Redundant "if"
--
Alan Modra
IBM OzLabs - Linux Technology Centre