This is the mail archive of the
binutils@sources.redhat.com
mailing list for the binutils project.
Re: bfd-in2.h change breaks objdump
- From: Michael Snyder <msnyder at redhat dot com>
- To: "Svein E. Seldal" <Svein dot Seldal at solidas dot com>
- Cc: Michael Snyder <msnyder at cygnus dot com>, binutils at sources dot redhat dot com, m dot hayes at elec dot canterbury dot ac dot nz
- Date: Fri, 13 Sep 2002 15:13:27 -0700
- Subject: Re: bfd-in2.h change breaks objdump
- Organization: Red Hat, Inc.
- References: <200209132025.g8DKPwl23993@reddwarf.sfbay.redhat.com> <3D825DB4.8070603@solidas.com>
"Svein E. Seldal" wrote:
>
> Michael Snyder wrote:
> > On 8-27-2001, Michael Hayes checked in a change to bfd-in2.h that
> > among other things deleted the definition of HAS_LOAD_PAGE.
>
> Hello,
>
> I'm the person responsible for this commit (Hayes is the author, but I
> arranged the commit), and I francly dont know what you're refering to.
> Removed, you say? HAS_LOAD_PAGE has never been removed (by me at least).
>
> A quick cvs update and then a grep revealed these occurences of
> HAS_LOAD_PAGE:
>
> bfd/bfd-in.h:272:#define HAS_LOAD_PAGE 0x1000
> bfd/bfd-in2.h:278:#define HAS_LOAD_PAGE 0x1000
> bfd/coff-tic4x.c:359: HAS_SYMS | HAS_LOCALS | WP_TEXT | HAS_LOAD_PAGE ),
> bfd/coff-tic4x.c:403: HAS_SYMS | HAS_LOCALS | WP_TEXT | HAS_LOAD_PAGE ),
> bfd/coff-tic4x.c:448: HAS_SYMS | HAS_LOCALS | WP_TEXT | HAS_LOAD_PAGE ),
> bfd/coff-tic4x.c:493: HAS_SYMS | HAS_LOCALS | WP_TEXT | HAS_LOAD_PAGE ),
> bfd/coff-tic4x.c:538: HAS_SYMS | HAS_LOCALS | WP_TEXT | HAS_LOAD_PAGE ),
> bfd/coff-tic4x.c:583: HAS_SYMS | HAS_LOCALS | WP_TEXT | HAS_LOAD_PAGE ),
> binutils/ChangeLog:28: * objdump.c (dump_headers): Add printing of
> HAS_LOAD_PAGE flag.
> binutils/objdump.c:373: if (abfd->flags & HAS_LOAD_PAGE)
> binutils/objdump.c:2008: PF (HAS_LOAD_PAGE, "HAS_LOAD_PAGE");
>
> So I guess your CVS repository is probably obsoleted. The latest CVS
> version of bfd/bfd-in2.h is 1.169.
Ouch -- you're right. I missed an old sticky tag.
Sorry, please disregard.