This is the mail archive of the
binutils@sources.redhat.com
mailing list for the binutils project.
gas trivia
- From: Alan Modra <amodra at bigpond dot net dot au>
- To: binutils at sources dot redhat dot com
- Date: Sat, 21 Sep 2002 20:06:19 +0930
- Subject: gas trivia
* config/tc-i386.c (md_apply_fix3): Replace S_IS_EXTERNAL,
S_IS_WEAK etc. with S_FORCE_RELOC call. Correct comment.
Rename "fseg" to "sym_seg".
* Makefile.am: Run "make dep-am".
* Makefile.in: Regenerate.
Index: gas/config/tc-i386.c
===================================================================
RCS file: /cvs/src/src/gas/config/tc-i386.c,v
retrieving revision 1.130
diff -u -p -r1.130 tc-i386.c
--- gas/config/tc-i386.c 19 Sep 2002 19:01:12 -0000 1.130
+++ gas/config/tc-i386.c 21 Sep 2002 09:25:47 -0000
@@ -4620,19 +4620,16 @@ md_apply_fix3 (fixP, valP, seg)
#if defined (OBJ_ELF) || defined (OBJ_MAYBE_ELF)
if (OUTPUT_FLAVOR == bfd_target_elf_flavour)
{
- segT fseg = S_GET_SEGMENT (fixP->fx_addsy);
+ segT sym_seg = S_GET_SEGMENT (fixP->fx_addsy);
- if ((fseg == seg
+ if ((sym_seg == seg
|| (symbol_section_p (fixP->fx_addsy)
- && fseg != absolute_section))
- && !S_IS_EXTERNAL (fixP->fx_addsy)
- && !S_IS_WEAK (fixP->fx_addsy)
- && S_IS_DEFINED (fixP->fx_addsy)
- && !S_IS_COMMON (fixP->fx_addsy))
+ && sym_seg != absolute_section))
+ && !S_FORCE_RELOC (fixP->fx_addsy))
{
/* Yes, we add the values in twice. This is because
- bfd_perform_relocation subtracts them out again. I think
- bfd_perform_relocation is broken, but I don't dare change
+ bfd_install_relocation subtracts them out again. I think
+ bfd_install_relocation is broken, but I don't dare change
it. FIXME. */
value += fixP->fx_where + fixP->fx_frag->fr_address;
}
--
Alan Modra
IBM OzLabs - Linux Technology Centre